dataverse icon indicating copy to clipboard operation
dataverse copied to clipboard

adding fix to file name for download guestbook responses

Open stevenwinship opened this issue 1 year ago • 4 comments

When using the Chrome browser to download the guestbook of a Dataverse collection that has a comma in the collection's name, such as the collection named "Representation, Treatment, Outcome" the file name is truncated to Representation.

Closes https://github.com/IQSS/dataverse/issues/9401

Special notes for your reviewer:

Suggestions on how to test this: test by creating a collection with commas in the name and setting up guestbook. Then, download using Chrome, Safari, and Firefox.

Does this PR introduce a user interface change? If mockups are available, please link/include them here: No

Is there a release notes update needed for this change?: No

Additional documentation: Also removes other chars that could cause issues when used in a file name.

stevenwinship avatar Jun 05 '24 17:06 stevenwinship

Coverage Status

coverage: 20.573%. remained the same when pulling 40503758427f6c2bae790f7ead45844af20293e9 on 9401-fix-truncated-collection-name-guestbook-csv-file into 3c55c3fa503b200fbe3b20e8d7d8965424e71160 on develop.

coveralls avatar Jun 05 '24 18:06 coveralls

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:9401-fix-truncated-collection-name-guestbook-csv-file
ghcr.io/gdcc/configbaker:9401-fix-truncated-collection-name-guestbook-csv-file

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] avatar Jun 05 '24 18:06 github-actions[bot]

Coverage Status

coverage: 20.574% (+0.001%) from 20.573% when pulling 88877a44f5ac0e52168c0b86841fae5bd9d09ca6 on 9401-fix-truncated-collection-name-guestbook-csv-file into 3c55c3fa503b200fbe3b20e8d7d8965424e71160 on develop.

coveralls avatar Jun 05 '24 20:06 coveralls

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:9401-fix-truncated-collection-name-guestbook-csv-file
ghcr.io/gdcc/configbaker:9401-fix-truncated-collection-name-guestbook-csv-file

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] avatar Jun 05 '24 20:06 github-actions[bot]