dataverse icon indicating copy to clipboard operation
dataverse copied to clipboard

IQSS/10450 - Fixes for Globus download (transfer out) and related info messages

Open qqmyers opened this issue 10 months ago • 0 comments

What this PR does / why we need it: The PR fixes the issue with multifile Globus transfers out/downloads not working for draft datasets. It also improves handling of cases where ineligible files are selected for download or Globus transfer by only showing the download/transfer mechanisms that will work (on some files) given the files in the dataset and by improving the UI messages to indicate that files may not be eligible either because the user doesn't have permission (restricted or embargoed), or because the files can't be downloaded/transferred (i.e. files not in a Globus store when the user tries a Globus transfer or files in a Globus store that doesn't support normal downloads when the user selects download.)

Which issue(s) this PR closes:

Closes #10450

Special notes for your reviewer: The bug will affect Globus downloads in the current develop/6.2 candidate. W.r.t. messaging, this PR does some cleanup so that the popup dialogs make more sense when Globus is used. FWIW: PR #10336 is ready for QA and will add another potential case (files that are not accessible due to their retention period having expired.) For/after that PR, we could consider trying to simplify the messaging, and or highlighting which files are ineligible for which reason. (Moving the logic to Java might make it easier to handle the mixed cases versus trying to keep the current logic with JSF ? operators to choose between fixed bundle strings.)

Suggestions on how to test this: Per the issue, create a dataset with a mix of Globus and non-globus files and verify a) that Globus transfer from a draft dataset works (nominally that Dataverse attempts to launch the Dataverse-Globus app for this case), and b) that selecting either download Original or Globus Transfer from the Access menu or file table Download menu shows correct dialog messages, and c) that if there are no downloadable files in the dataset (only Globus transferrable ones) that the download Original/Tabular options don't appear.

Does this PR introduce a user interface change? If mockups are available, please link/include them here: Only changes strings which are readable in the Bundle file.

Is there a release notes update needed for this change?:

Additional documentation:

qqmyers avatar Mar 29 '24 21:03 qqmyers