IQSS
Fix intermittent IT test failures for HarvestingClientsIT
Description: Intermittent failures happen during IT tests pointing to HarvestingClientsIT
Closes: #10438
How to test this: Observe other PRs and see if any fail on this test
:package: Pushed preview images as
ghcr.io/gdcc/dataverse:10438-fix-intermittent-harvesting-tests
ghcr.io/gdcc/configbaker:10438-fix-intermittent-harvesting-tests
:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
:package: Pushed preview images as
ghcr.io/gdcc/dataverse:10438-fix-intermittent-harvesting-tests
ghcr.io/gdcc/configbaker:10438-fix-intermittent-harvesting-tests
:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.
:package: Pushed preview images as
ghcr.io/gdcc/dataverse:10438-fix-intermittent-harvesting-tests
ghcr.io/gdcc/configbaker:10438-fix-intermittent-harvesting-tests
:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.
:package: Pushed preview images as
ghcr.io/gdcc/dataverse:10438-fix-intermittent-harvesting-tests
ghcr.io/gdcc/configbaker:10438-fix-intermittent-harvesting-tests
:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.
:package: Pushed preview images as
ghcr.io/gdcc/dataverse:10438-fix-intermittent-harvesting-tests
ghcr.io/gdcc/configbaker:10438-fix-intermittent-harvesting-tests
:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.
:package: Pushed preview images as
ghcr.io/gdcc/dataverse:10438-fix-intermittent-harvesting-tests
ghcr.io/gdcc/configbaker:10438-fix-intermittent-harvesting-tests
:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.
:package: Pushed preview images as
ghcr.io/gdcc/dataverse:10438-fix-intermittent-harvesting-tests
ghcr.io/gdcc/configbaker:10438-fix-intermittent-harvesting-tests
:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.
Added back the assert for exact harvest count and added an extra second to the wait.
When/if Jenkins comes back to life, if the tests complete w/out failing 3 times in a row with this extra second added, I'll vote for merging it quickly; if it keeps happening, we'll revisit it then.
@stevenwinship Could you please sync the branch up with develop, appears to be the reason the last Jenkins run bombed.
:package: Pushed preview images as
ghcr.io/gdcc/dataverse:10438-fix-intermittent-harvesting-tests
ghcr.io/gdcc/configbaker:10438-fix-intermittent-harvesting-tests
:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.
one successful run earlier today (build 14). build 15: a really weird failure - the other harvesting test, testHarvestingClientRun_AllowHarvestingMissingCVV_True, 4 datasets harvested instead of 8. (??)
Don has fixed the payara distribution issue. But it's still Jenkins roulette, with the harvesting tests failing half of the times; somehow it's been made worse so far. So no, we are not merging this PR just yet. If I have time I'll look into it some more.
ok, one mystery solved - I just left a comment in #10464, the PR I merged yesterday; the new errors are the result of the extra check added, which is performed before the async. indexing gets a chance to finish.
:package: Pushed preview images as
ghcr.io/gdcc/dataverse:10438-fix-intermittent-harvesting-tests
ghcr.io/gdcc/configbaker:10438-fix-intermittent-harvesting-tests
:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.
also, just saw that you have fixed it already.
OK, you have fixed the cleanup part - but the search check in line 278 may still bomb for the same async. reason - ? ... I'll shut up and let you handle this.
:package: Pushed preview images as
ghcr.io/gdcc/dataverse:10438-fix-intermittent-harvesting-tests
ghcr.io/gdcc/configbaker:10438-fix-intermittent-harvesting-tests
:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.
:package: Pushed preview images as
ghcr.io/gdcc/dataverse:10438-fix-intermittent-harvesting-tests
ghcr.io/gdcc/configbaker:10438-fix-intermittent-harvesting-tests
:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.
Anyway, I just want to see it pass a few times in a row and merge it without further ado.
:package: Pushed preview images as
ghcr.io/gdcc/dataverse:10438-fix-intermittent-harvesting-tests
ghcr.io/gdcc/configbaker:10438-fix-intermittent-harvesting-tests
:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.
There were more annoying unrelated Jenkins failures. But the 2 harvesting tests have objectively passed three times in a row. Merging.