dataverse icon indicating copy to clipboard operation
dataverse copied to clipboard

#10442 fix null from template

Open sekmiller opened this issue 1 year ago • 3 comments

What this PR does / why we need it: Fixes an issue where new datasets created in UI with template are failing to index

Which issue(s) this PR closes:

Closes #10442 Datasets created via template are not indexed

Special notes for your reviewer: This is a BandAid(tm) fix. Needed for 6.2. Should probably revisit templates to see why there are nulls getting into the controlled vocab values.

Suggestions on how to test this: This only seems to effect templates that were created prior to the current release/dev environment, so to test you need to go to Dataverse-internal and create a dataset using the template named "check23". A dataset created from this template will not be indexed if you are in the current dev branch, but it will be indexed in this PR branch. Create a dataset with that template. It should be indexed properly.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

sekmiller avatar Mar 28 '24 13:03 sekmiller

Coverage Status

coverage: 20.716%. remained the same when pulling 08c5b90ec6b1678bd7881b45521dc64fb3138a73 on 10442-index-draft-from-template into 834bd64aafc3a4e6a194e52603f4e82ac6b2424e on develop.

coveralls avatar Mar 28 '24 13:03 coveralls

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10442-index-draft-from-template
ghcr.io/gdcc/configbaker:10442-index-draft-from-template

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] avatar Mar 28 '24 14:03 github-actions[bot]

Related PR:

  • #10323

pdurbin avatar Mar 28 '24 16:03 pdurbin

I just tested it on dataverse-internal (before and after the fix). Works great. Merging.

pdurbin avatar Apr 01 '24 15:04 pdurbin