dataverse icon indicating copy to clipboard operation
dataverse copied to clipboard

Grant/deny access request link includes faulty "." in email

Open DieuwertjeBloemen opened this issue 1 year ago • 2 comments

What steps does it take to reproduce the issue? A user sending an access request.

  • When does this issue occur? In the email that the dataset users that have grant permission roles get once an access request has been sent.

  • Which page(s) does it occurs on? In the email (https://github.com/IQSS/dataverse/blob/develop/src/main/java/propertyFiles/Bundle.properties in "notification.email.requestFileAccess=File access requested for dataset: {0} by {1} ({2}). Manage permissions at {3}.", I believe)

  • What happens? The link to grant/deny the permissions is followed by a full stop, which by some email programs, like outlook, is seen as part of the link. This results in a non-functioning link, unless you delete the full stop from the end in the url bar. The landing page you get is also quite confusing as it looks to be the right page, just without any requests and without having to log in.

  • To whom does it occur (all users, curators, superusers)? All users who can grant/deny access to files.

  • What did you expect to happen? To land on the actual page to grant/deny access

Which version of Dataverse are you using? 5.14

Any related open or closed issues to this bug report?

Screenshots: image

DieuwertjeBloemen avatar Mar 18 '24 14:03 DieuwertjeBloemen

FWIW: A work-around/potential fix is to add a space before the period in the Bundle.properties entry - I think this has been done in other places.

qqmyers avatar Mar 18 '24 15:03 qqmyers

@DieuwertjeBloemen thanks for opening this issue. I know we discussed it in Mexico.

Yes, simply adding a space sounds like a good fix. Pull requests welcome!

pdurbin avatar Mar 19 '24 13:03 pdurbin

I made a pull request:

  • #11115

pdurbin avatar Dec 19 '24 19:12 pdurbin