IQSS
IQSS/10117-increase-guestbook-question-length
What this PR does / why we need it: This PR increases the allowed length of a custom question (was 255 chars, now up to limit of the postgres text type) and fixes the code that was hiding any error when a guestbook create/edit failed (due to this or other reason causing a CommandException).
Which issue(s) this PR closes:
Closes #10117 Closes #9492
Special notes for your reviewer: Accidentally committed to develop, reverted everything, and added a new commit here to restore everything.
Suggestions on how to test this: Try creating/editing a guestbook with a custom question over 255 chars in length. Before the PR, you'll see a success message and no new guestbook/guestbook update. After the PR, the change will succeed. If you also want to test the error fix, run ALTER TABLE customquestion ALTER COLUMN questionstring TYPE varchar(10); or similar low number and try to add a question longer than that. (setting TYPE back to text as in the flyway script will restore your db).
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: fairly minor issue but I added one
Additional documentation:
coverage: 21.854%. remained the same when pulling 1d300f444184d946411e45582b2f649ed9902976 on QualitativeDataRepository:IQSS/10117-customquestion_limit_and_failure into befc5a9ee6dae1b0542c584ee8f2b57c796a0a76 on IQSS:develop.
@stevenwinship @qqmyers @ofahimIQSS Jenkins tests are failing. Does anyone know why?
@stevenwinship @qqmyers @ofahimIQSS Jenkins tests are failing. Does anyone know why?
[Pipeline] script [Pipeline] { [Pipeline] fileExists [Pipeline] error [Pipeline] } [Pipeline] // script [Pipeline] } [Pipeline] // stage [Pipeline] } [Pipeline] // withEnv [Pipeline] } [Pipeline] // node [Pipeline] End of Pipeline ERROR: Ansible run terminated abnormally, failing build.
GitHub has been notified of this commit’s build result
Finished: FAILURE
"System is booting up. Unprivileged users are not permitted to log in yet. Please come back later. For technical details, see pam_nologin(8)." Connection closed by 3.236.18.81 port 22 lost connection
Hi! Has this been fixed? I'm working on a guestbook through Borealis and still have this issue. Thanks!
It's fixed as of v6.5. Borealis is running a customized 'v6.4.1-SP' and so probably doesn't have the fix yet.