dataverse-client-python icon indicating copy to clipboard operation
dataverse-client-python copied to clipboard

Added possibilty to switch ssl verification off

Open dwintergruen opened this issue 8 years ago • 3 comments

Helps testing on self-signed servers.

dwintergruen avatar Sep 21 '16 14:09 dwintergruen

No I haven’t realized this change. D

Am 21.09.2016 um 16:15 schrieb Philip Durbin [email protected]:

@pdurbin requested changes on this pull request.

@dwintergruen you seem to be reverting e17d8f9 which is a fix for IQSS/dataverse#3326 . Is this intentional?

In dataverse/file.py:

@@ -19,10 +19,6 @@ def init(self, dataset, name, file_id=None):

 @classmethod
 def from_json(cls, dataset, json):
  •    try:
    
  •        name = json['dataFile']['filename']
    
  •        file_id = json['dataFile']['id']
    
  •    except KeyError:
    
  •        name = json['datafile']['name']
    
  •        file_id = json['datafile']['id']
    
  •    name = json['datafile']['name']
    
  •    file_id = json['datafile']['id']
    

@dwintergruen you seem to be reverting e17d8f9 which is a fix for IQSS/dataverse#3326 . Is this intentional?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

dwintergruen avatar Sep 21 '16 14:09 dwintergruen

@dwintergruen ok, can you please update your pull request? Thanks!!

pdurbin avatar Sep 21 '16 14:09 pdurbin

Just adding a +1 for fixing this issue. I'm having problems with exactly this.

rhandberg avatar Mar 23 '17 12:03 rhandberg