dataverse-client-python
dataverse-client-python copied to clipboard
IQSS
Remove references to apitest.dataverse.org (demo server instead)
Per https://github.com/IQSS/dataverse/issues/3345 we are shutting down the server https://apitest.dataverse.org so the two references in this repo should be changed to use server https://demo.dataverse.org instead:
- readme.md
- dataverse/settings/defaults.py
@TomBaxter are you interested in taking on this issue? You were mentioned by @mfraezz at https://github.com/CenterForOpenScience/osf.io/pull/5344#issuecomment-225929790
Looked easy, so I just quick did it. https://github.com/IQSS/dataverse-client-python/pull/37
Cheers
On Wed, Sep 14, 2016 at 2:29 PM, Philip Durbin [email protected] wrote:
@TomBaxter https://github.com/TomBaxter are you interested in taking on this issue? You were mentioned by @mfraezz https://github.com/mfraezz at CenterForOpenScience/osf.io#5344 (comment) https://github.com/CenterForOpenScience/osf.io/pull/5344#issuecomment-225929790
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/IQSS/dataverse-client-python/issues/36#issuecomment-247110486, or mute the thread https://github.com/notifications/unsubscribe-auth/AAY2ZzNtZLfjP-e82V8ypmBkRh9T65FGks5qqD0OgaJpZM4J9Ftq .
....... ___o
........<,
..... ()/() \o
@TomBaxter thanks for making pull request #37! As I said at https://github.com/IQSS/dataverse-client-python/pull/37#issuecomment-247123986 the change you made looks good but the Travis tests are failing (#32). What do you think? Merge it anyway? I'd love for the Travis tests to be working again but I'm not sure why they started failing. There are some more details in #32.
Assuming demo.dataverse.org has the same API as apitest.dataverse.org did this seems to me safe to merge. Getting Travis tests to pass seems like a high priority. Unfortunately, I don't yet have a lot of experience with the dataverse API or client yet. I've been led to believe that dataverse will get to the top of my to do list at some point, but I'm not sure when. I'll discuss with the boss man.
@TomBaxter sounds good! I'm actually a little concerned about the API change from Dataverse 4.4 to 4.5 that @felliott reported at https://github.com/IQSS/dataverse/issues/3326
However, his fix was in waterbutler (not this repo) at https://github.com/CenterForOpenScience/waterbutler/commit/1d803b14a678ee88e599bf25809d890cbfe0d612 so I'm not sure if the change will be noticed or not.
The change is "datafile" vs "dataFile" at https://github.com/IQSS/dataverse-client-python/blob/v0.1.2/dataverse/file.py . Maybe that should be a separate issue though.
I'm all in favor of having Dataverse get to the top of your list. Please let me know if there's anything I can do to help!
@pdurbin: I've seen the particular error mentioned in #32 (the zipping error, not the key error) when some of our interns were still connecting to apitest.dataverse.org. IIRC, the issue was that apitest was still running DV v4.2, which wasn't auto-unzipping uploads and downloads. Since your tests seems to still be running against apitest I suspect this PR will fix #32 as well. I've talked to @TomBaxter, he's going to update https://github.com/IQSS/dataverse-client-python/pull/37 to fix the key error Travis failures, too. After that, I hope, hope, hope that Travis should be green again.
@pdurbin Are there specific versions of python that dataverse supports? The reason I ask is because the latest version of flake8 requires python>=2.7, but the .travis.yml file tests python 2.6, 2.7, and 3.3. The 2.6 is failing on flake8 itself. To pass Travis we will need to either pin flake8 to an older version or drop python 2.6 from testing/support.
@TomBaxter I think we'd be happy if Python 2.7 and any version of Python 3 is supported. @rliebz set up the Travis tests originally (thanks!) and I still feel a little guilty about disabling the 3.4 tests: https://github.com/IQSS/dataverse-client-python/commits/master/.travis.yml
This is a roundabout way to say that I think it's fine to drop Python 2.6 support. 😄
If you want I can drop a note to https://groups.google.com/forum/#!forum/dataverse-community and in http://chat.dataverse.org to see if anyone feels strongly about Python 2.6.