EMU-webApp icon indicating copy to clipboard operation
EMU-webApp copied to clipboard

Saving back a modified track file _fails_ due to unsupported column type error

Open FredrikKarlssonSpeech opened this issue 3 years ago • 5 comments

I have a single track overlayed on the spectrogram. When I edit it and sync it back to the server, I get the error:

Skärmavbild 2022-02-24 kl  11 20 21

Not being to save back a well-formated SSFF track to the server is a serious issue.

FredrikKarlssonSpeech avatar Feb 24 '22 10:02 FredrikKarlssonSpeech

The issue is that while the web app opens and manipulates SSFF tracks fine, it refuses to store the track unless it is "INT16" format.

FredrikKarlssonSpeech avatar Feb 24 '22 13:02 FredrikKarlssonSpeech

Hi @FredrikKarlssonSpeech - this has been a long time issue. I've made a pull request that fixes the problem. #311

samgregory avatar Mar 11 '22 00:03 samgregory

I have reviewed PR #311 and added a little code to it. I will make a new release containing the fix this week, so @FredrikKarlssonSpeech you can test it. Thanks again for the report and the PR.

MJochim avatar Mar 21 '22 14:03 MJochim

I just released this fix with v1.4.0. @FredrikKarlssonSpeech can you confirm that it works now and your data are written out correctly?

I am not yet closing this issue, because I would like some feedback on whether it works as intended. A bug in writing out data would be pretty bad. I was careful in reviewing @samgregory’s fix and didn’t spot an error. But nothing beats a test with real data.

MJochim avatar Mar 22 '22 11:03 MJochim

@FredrikKarlssonSpeech Do you have any feedback on this?

MJochim avatar Nov 04 '22 19:11 MJochim