maestro icon indicating copy to clipboard operation
maestro copied to clipboard

Fixedstep config validation missing

Open lausdahl opened this issue 3 years ago • 0 comments

The test examples contains config.json data which is send in through expansion but the data they contain is not even related to the model loaded through the env.json file. These files should be validated. All parameters must be resolvable otherwise you may not discover that some of these are never set.

Exmaple initialize_singleWaterTank:

{
  "fmus": {
    "{x1}": "target/test-classes/watertankcontroller-c.fmu",
    "{x2}": "target/test-classes/singlewatertank-20sim.fmu"
  },
  "connections": {
    "{x1}.crtlInstance.valve": [
      "{x2}.wtInstance.valvecontrol"
    ],
    "{x2}.wtInstance.level": [
      "{x1}.crtlInstance.level"
    ]
  },
  "algorithm": {
    "type": "fixed-step",
    "size": 0.001
  },
  "end_time": 10.0
}

does not match:

{
  "parameters": {
    "{crtl}.crtlInstance.maxlevel": 2,
    "{crtl}.crtlInstance.minlevel": 1
  },
  "verifyAgainstProlog": true,
  "stabilisation": true,
  "fixedPointIteration": 5,
  "absoluteTolerance": 0.1,
  "relativeTolerance": 0.1
}

lausdahl avatar Jun 10 '21 18:06 lausdahl