maestro icon indicating copy to clipboard operation
maestro copied to clipboard

Threaded Web API test passes although Web server fails to start

Open FrederikPM opened this issue 3 years ago • 5 comments

The test Threaded Web API test executed by the test_simultaneous_simulations.py script as part of the github actions workflow passes although it states that the test fails to start the web server with the following description: "Web server failed to start. Port 8082 was already in use.".

FrederikPM avatar May 10 '21 08:05 FrederikPM

@maxs-rose can you look into this?

FrederikPM avatar May 10 '21 08:05 FrederikPM

That occurs when the previous script fails to shutdown maestro. I think its a problem with python being unable to stop Java processes sometimes and I am not entirely sure how to solve it

maxs-rose avatar May 10 '21 09:05 maxs-rose

Ah okay. So it connects to the Maestro instance created by the previous test on port 8082 as it is not shutdown and this is why it passes although the port is in use? Could a workaround then be to check if the port is in use and if so find a free port for the Maestro intance that is to be instantiated for the test?

FrederikPM avatar May 10 '21 09:05 FrederikPM

I think that could be a workaround. Will have a look into it

maxs-rose avatar May 10 '21 09:05 maxs-rose

Thanks! :)

FrederikPM avatar May 10 '21 09:05 FrederikPM