spoon icon indicating copy to clipboard operation
spoon copied to clipboard

review doc: correct typo "upcall" to "call"

Open chammp opened this issue 3 years ago • 1 comments

Just fixing a small typo in a couple of Javadoc comments. Methods just call each other 😉

chammp avatar Sep 15 '22 08:09 chammp

"Upcall" is sometimes used in the sense of "calling a callback function". I think the word is esoteric at best and don't mind seeing it removed.

slarse avatar Sep 21 '22 18:09 slarse

Thanks @chammp!

As an aside: Your commit was authored by a mail not associated with your GitHub account (I assume) so GitHub insisted on changing it to one that is. If you do not want this to happen, you should probably either add the gmail address to your GitHub profile or commit with the GitHub mail. If the discrepancy is intended, we might be able to figure something out next time :)

I-Al-Istannen avatar Sep 23 '22 20:09 I-Al-Istannen

Thanks @chammp!

As an aside: Your commit was authored by a mail not associated with your GitHub account (I assume)

True. That was a mistake on my side when manually configuring the email address for this repo with git command line X_x. Thanks for the heads up :)

chammp avatar Sep 23 '22 20:09 chammp