chore(deps): update dependency org.apache.maven.plugins:maven-javadoc-plugin to v3.4.1

[renovate[bot]]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
org.apache.maven.plugins:maven-javadoc-plugin	3.3.2 -> 3.4.1

---

⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• [ ] If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by Mend Renovate. View repository job log here.

[monperrus]

The error is

Error:  Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.3:site (default-site) on project spoon-core: Execution default-site of goal org.apache.maven.plugins:maven-site-plugin:3.3:site failed.: UndeclaredThrowableException: InvocationTargetException: Receiver class org.apache.maven.plugins.javadoc.JavadocReport does not define or inherit an implementation of the resolved method 'abstract void generate(org.codehaus.doxia.sink.Sink, java.util.Locale)' of interface org.apache.maven.reporting.MavenReport. -> [Help 1]

Google does not know about it.

[I-Al-Istannen]

The site plugin is outdated. We'd need to add

<plugin>
  <groupId>org.apache.maven.plugins</groupId>
  <artifactId>maven-site-plugin</artifactId>
  <version>3.12.0</version>
</plugin>

to the plugin management section in the spoon-pom. The "project info reports plugin" at least is also laughably out of date (~8 years).

Maybe updating all the dependencies in the spoon-pom project would be a good idea - it seems like renovate skips them?

[MartinWitt]

I'm somewhat scared that the PR is suddenly green now. Maybe something in our configuration changed?

[slarse]

It is rather odd, the site plugin has not been updated. I even checked, the default site plugin for Maven 3.8.6 (which is what is running in GH actions) is still 3.3.

But let's just go ahead with @I-Al-Istannen's idea of updating (and, specifying to begin with) the default plugins.