fix static analysis warnings by SonarQube

[zielint0]

Warning list: https://sonarqube.ow2.org/project/issues?id=fr.inria.gforge.spoon%3Aspoon-core&resolved=false&types=BUG

I am using IDEA checkers to improve our code base but, at the same time some Sonar defects are solved as well (some checkers overlap).

I am going to fix all true positives on SonarQube on regular basis.

Today (2018-07-16) I am starting with 2076 issues to fix.

One more time I would like to get labels:

• code inspection (yellow) - to mark IDEA inspections
• sonarqube (orange) - to mark SonarQube inspections

to manage PRs with fixes. Also it would be change color of "bug" to RED :)

"refactor" label is better suited for refactoring of pure functionality (for instance: rework parser to support syntax X).

[zielint0]

@surli How often SonarQube results of analysis are refreshed?

[TheMarvelFan]

Hi can someone guide me how to start working on this issue?

[MartinWitt]

We no longer use SonarQube anymore, so this issue is finished. But IntelliJ still highlights a few warnings which you could fix.

[TheMarvelFan]

@MartinWitt Hi can you please provide details about these warnings, and how to recreate them?