link-roundups icon indicating copy to clipboard operation
link-roundups copied to clipboard

Link Roundup styles for Saved Links interfere with WordPress' emoji substitution

Open benlk opened this issue 6 years ago • 0 comments

Following from #177, a Saved Link with the title "brittany renee :cherry_blossom: on Twitter" will be displayed with the following markup in the post:

<p class="lr-saved-link ">
	<a href="https://twitter.com/BritRenee_/status/1133459151655456769">
		brittany renee
		<img draggable="false" class="emoji" alt="🌸" src="https://s.w.org/images/core/emoji/12.0.0-1/svg/1f338.svg">
		on Twitter
	</a>
	–
	<span class="description">"Very Important Question: What's your favorite episode of your favorite tv show?! Right now, mine is Psych s7e11"</span>
	<em>Twitter</em>
</p>

In that markup, the image is inline.

And in Link Roundups' main CSS, it appears thusly:

Screen Shot 2019-05-28 at 19 08 16

https://github.com/INN/link-roundups/blob/8b8d6efe9708fbc85e477828cf3f962936675af9/less/lroundups.less#L17-L20

  • [ ] give that image a more-specific selector in the default Saved Link markup option
  • [ ] update CSS
  • [ ] check that it works for sites that have saved a different image markup in the Link Roundups settings
  • [ ] check that it works in the Saved Links List widget

benlk avatar May 29 '19 00:05 benlk