Change from Java EE to Jakarta EE to allow BLS to run in Tomcat 10

[jan-niestadt]

see https://inl.github.io/BlackLab/blacklab-server-overview.html#installation

[jan-niestadt]

Will this mean BLS only works on Tomcat 10 and no longer on older versions? Look into this.

[eduarddrenth]

I can take on this one (but not before oktober I'm afraid), I've migrated multiple apps to EE 10 already and would like to run blacklab on payara 6 (requires EE 10). We might need to use a maven classifier

[jan-niestadt]

That would be great! Could the two versions be built from the exact same source code, or would we need to maintain separate branches? Separate branches would be a bit of a pain, but doable if necessary.

At INT we'll probably stick with Tomcat 9 for the time being, but it's good to have the option and be prepared for T9's inevitable end-of-life.

[eduarddrenth]

I still want to do this, jakarta ee 10 and jdk 17 as well.

[jan-niestadt]

@KCMertens and I had a quick go at this but ran into some trouble, don't remember exactly what, but see branch experiment/tomcat-10. Maybe we can have a look when you're in Leiden soon.

[eduarddrenth]

This branch compiles: https://github.com/fryske-akademy/BlackLab/tree/experiment/tomcat-10

small TODO's in FileUploadHandler and UserRequestSolr.

solr core uses javax.servlet in HttpSolrCall via dependency https://mvnrepository.com/artifact/org.eclipse.jetty.toolchain/jetty-servlet-api/4.0.6

1 test failing: TestSearchComponent

[eduarddrenth]

server runs in payara 6

[eduarddrenth]

solr does not provide a jakarta ee compatible version yet, excluded this module for now in my fork. The rest seems fine

[eduarddrenth]

performed big merge with dev, still running on payara 6 jdk 17

[jan-niestadt]

Nice! The Solr problem was probably also why we got stuck. And we still run Java 11 on many servers, although it would be good to upgrade.

But we can just keep this branch around for those who want to use it until this is resolved and we can merge it into main.

I'll pull in your changes soon. I think I'll try to rebase this branch on dev instead of merging; I like having as clean as history as possible.

[eduarddrenth]

Keep in mind I commented out solt module

Op vr 2 feb. 2024 11:27 schreef Jan Niestadt @.***>:

Nice! The Solr problem was probably also why we got stuck. And we still run Java 11 on many servers, although it would be good to upgrade.

But we can just keep this branch around for those who want to use it until this is resolved and we can merge it into main.

I'll pull in your changes soon. I think I'll try to rebase this branch on dev instead of merging; I like having as clean as history as possible.

— Reply to this email directly, view it on GitHub https://github.com/INL/BlackLab/issues/321#issuecomment-1923516308, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACN2KKHOSHOAIL6CR25LTADYRS5SRAVCNFSM54PMCXH2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJSGM2TCNRTGA4A . You are receiving this because you commented.Message ID: @.***>

[KCMertens]

Just chiming in that SOLR is indeed why the migration to EE 10 isn't done yet.

Though I did come across this. It seems like maybe we can deploy in Tomcat 10 despite still relying on javax.* packages? Though it would need some testing.