neuroshapes icon indicating copy to clipboard operation
neuroshapes copied to clipboard

"Date of surgery" should allow multiple values

Open apdavison opened this issue 7 years ago • 3 comments

In core/subject/v0.1.0.json, nsg:dateOfSurgery has "maxCount": 1

For subjects with chronically implanted electrodes, or multiple electrode arrays, it is possible to have more than one surgery, on different days.

Similar remarks apply to nsg:disease and nsg:treatment. These could in principle have multiple values.

apdavison avatar Jul 13 '18 13:07 apdavison

Hi, This is an interesting point. If many dates of surgery are possible for a given subject than a nsg:dateOfSurgery value should belong to the experiment activity which performs the "surgery" I think. Multiple dates of surgery within an array may lead to confusion .

Okay for nsg:disease and nsg:treatment.

What do you @annakristinkaufmann ?

MFSY avatar Jul 13 '18 15:07 MFSY

ok, I agree. That suggests removing nsg:dateOfSurgery altogether, then?

apdavison avatar Jul 13 '18 15:07 apdavison

I agree with you, @MFSY ! The reason we'd included it in the first place was that the nsg:dateOfSacrifice property couldn't be used for the date of human tissue extraction, so we've included nsg:dateOfSurgery as an additional property shape (since we did not want to model the surgery activity per se). We could also make this activity explicit and include it in there.

annakristinkaufmann avatar Jul 13 '18 16:07 annakristinkaufmann