ubergraph icon indicating copy to clipboard operation
ubergraph copied to clipboard

Add bridges between Uberon/CL and taxon-specific anatomy ontologies.

Open gouttegd opened this issue 2 years ago • 9 comments

This PR adds the Uberon-provided bridges that link Uberon/CL and all the taxon-specific anatomy/development ontologies that are already included in Ubergraph.

The added bridges are for:

  • MA
  • WBbt/WBls
  • ZFA
  • MmusDv
  • HAO
  • EMAPA
  • FBdv

closes #136

gouttegd avatar Jan 12 '24 13:01 gouttegd

@gouttegd in my experience Uberon and EMAPA are not really compatible when logically bridged. Has this been fixed?

balhoff avatar Jan 16 '24 01:01 balhoff

No. With Uberon’s disjointness axioms left in place, merging Uberon, EMAPA, and the Uberon-to-EMAPA bridge still yields ~1400 unsatisfiable classes.

gouttegd avatar Jan 16 '24 12:01 gouttegd

@dosumis @balhoff What is the intention here? Should those bridges be added only after the incompatibilities issues have been fixed?

gouttegd avatar Mar 01 '24 12:03 gouttegd

Ubergraph is meant to be a logically coherent system, and the relation-graph depends on that. We could add "mapping" versions of the bridges that aren't compatible, such as UBERON:femur skos:closeMatch EMAPA:femur. @dosumis what is your opinion?

balhoff avatar Mar 01 '24 17:03 balhoff

Agree we should keep it outside of the logic if it leads to so many inconsistencies. If we have a compelling use case for including EMAPA, maybe it should use SKOS for the bridge - at least until we have time to work on it. Grant gods willing, we may have funding next year.

dosumis avatar Mar 02 '24 21:03 dosumis

Note that EMAPA is not the only ontology to be currently incompatible with Uberon:

  • Uberon + EMAPA + Uberon-to-EMAPA bridge: 1519 unsats
  • Uberon + MA + Uberon-to-MA bridge: 512 unsats
  • Uberon + ZFA + Uberon-to-ZFA bridge: 196 unsats
  • Uberon + HAO + Uberon-to-HAO bridge: the entire ontology is inconsistent (owl:Thing inferred to be equivalent to owl:Nothing – this seems to be caused by a single bogus mapping, I’ll have a closer look later).

So do we only want the bridges that won’t cause inconsistencies?

gouttegd avatar Mar 04 '24 11:03 gouttegd

So do we only want the bridges that won’t cause inconsistencies?

I think yes, but would like to work towards fixing for ontologies that are

(a) used in resources we have a compelling case to integrate or where a species specific ontology has clear value in annotation of single cell data (possibly not case for MA, as CL/Uberon are already widely used and should be sufficient (b) the number of unsats suggests the work is manageable.

For now, I think that means ZFA. Also curious about whether we have a mapping from XAO. Potentially useful for community annotating Xenopus scRNAseq data.

I'm happy to have xref mappings for the others - using mappings in Uberon. That could be useful for EMAPA as we may want mappings to this for work at Sanger - it's possible we will have resources for this at some point in the near future if non-trivial.

dosumis avatar Mar 14 '24 18:03 dosumis

(b) the number of unsats suggests the work is manageable.

For now, I think that means ZFA

Of note, many of unsatisfiability issues with ZFA were spotted a long time ago and seemingly never addressed on either side.

It doesn’t necessarily mean those issues are not manageable, but I’d be wary of using the (relatively low) number of unsats as an indicator of how easy it would be to fix them.

Several of them seem to be the consequence of a fundamental incompatibility between Uberon and ZFA, where what ZFA calls a “head“ corresponds to the head and the neck in Uberon (incompatibility first flagged here, 10 years ago).

Also curious about whether we have a mapping from XAO.

We have ~600 mappings between Uberon and XAO. Using them to bridge the two ontologies yields 208 unsats.

gouttegd avatar Mar 19 '24 16:03 gouttegd

Converting to draft as it is going to take a while to fix the unsats between Uberon and the taxon-specific ontologies.

gouttegd avatar Jul 02 '24 01:07 gouttegd