ontology-development-kit icon indicating copy to clipboard operation
ontology-development-kit copied to clipboard

Switch profile validation on by default

Open cmungall opened this issue 2 years ago • 2 comments

But may have to wait for:

https://github.com/ontodev/robot/issues/1040

OR: validate-profile is performed on the end product, after missing declarations are injected

cmungall avatar Aug 11 '22 14:08 cmungall

I just found this line:

https://github.com/INCATools/ontology-development-kit/blob/efa8d96d92238a88b7d202457edd370ac8732574/template/src/ontology/Makefile.jinja2#L168

The message is a bit misleading: conversion to functional syntax is irrelevant, no? It's the merge step that repairs

cmungall avatar Aug 11 '22 14:08 cmungall

You are right, I never realised it was the merge step. convert -f ofn works as well (w/o merge) but merge is probably the better thing to do here. we can at least fix the comment

matentzn avatar Aug 12 '22 18:08 matentzn

The profile validation is already on as default (commit), it's part of the test pipeline.

I'll fix the comment.

anitacaron avatar Nov 16 '22 18:11 anitacaron