ontology-development-kit icon indicating copy to clipboard operation
ontology-development-kit copied to clipboard

Add tmp/{oid}-edit.owl as a goal to all pipeline to allow arbitrary preprocessing

Open matentzn opened this issue 3 years ago • 3 comments

Right now, running ontology preprocessing is cumbersome, in fact, not really possible: we kinda have to apply any changes like taxon constraint materialisation and others in complex custom chains, and even use tricks like SRC="tmp/edit.owl" in make, see FBbt pipeline. I think we should simply add a single preprocessing step:

SRCBUILD=tmp/$(ONT)-edit.owl
$(SRCBUILD): $(SRC)
      cp $< $@

and replace all references in the Makefile from $(SRC) to $(SRCBUILD). So by default, no global preprocessing is applied. If the user wants to apply global preprocessing, they simply overwrite $(SRCBUILD).

Feedback to this idea welcome.

matentzn avatar Feb 11 '22 10:02 matentzn

Explainer: customised preprocessing is currently not possible at all because there is no common goal on which all release artefacts depend other than $(SRC).

matentzn avatar Feb 11 '22 11:02 matentzn

Just a quick feedback in passing: love it! 👍

gouttegd avatar Feb 11 '22 11:02 gouttegd

@matentzn reminder

anitacaron avatar Apr 27 '22 13:04 anitacaron

in Dev version already https://github.com/INCATools/ontology-development-kit/pull/639, will be released in next version.

shawntanzk avatar Oct 31 '22 14:10 shawntanzk

Re-opening as there is a serious bug: --catalog does not work correctly.

matentzn avatar Nov 27 '22 13:11 matentzn

Bug was not real. Imagined.

matentzn avatar Dec 04 '22 13:12 matentzn