ontology-development-kit icon indicating copy to clipboard operation
ontology-development-kit copied to clipboard
verified publisher icon INCATools

Replace issue_template.md with multiple alternate templates

Open cmungall opened this issue 7 years ago • 18 comments

Example of how to do this https://github.com/ewels/MultiQC/tree/master/.github

Thanks @olgabot for the suggestion!

cmungall avatar Feb 04 '19 18:02 cmungall

Some suggestions from my HPO perspective:

  • Adding term
  • Adding synonym
  • Subclass revision
  • Logical definition revision
  • Textual definition revision
  • Obsoletion

drseb avatar Feb 27 '19 09:02 drseb

Also: new annotation+new term (i.e., not only add a new term, but suggest what the domain objects are that should be annotated to it).

pnrobinson avatar Feb 27 '19 10:02 pnrobinson

Correct. But maybe (to make things simpler) this should simply be added to "Adding term".

drseb avatar Feb 27 '19 10:02 drseb

As the trackers are used for ontology pipeline maintenance, I would like to add:

  • Questions about how to use the ontology
  • Feature requests for release pipeline (adding new QC test, new release artefact)
  • Bug report for ontology, release and continuous integration pipeline ("ontology is missing obo tag x! WHY?", "the pipeline generates labels twice", etc.

It would be especially great if issues thus created could be tagged accordingly and, even better, assigned immediately to some configurable (set of) person(s).

matentzn avatar Feb 27 '19 17:02 matentzn

Great suggestions! I'm not sure if this feature allows auto-assigning people (but it probably wouldn't be hard to get a bot to do it).

I wonder if we should provide all choices or keep to a more manageable set - and also focused around where we can provide simple ready to fill in fields. I can see how to do that for New-X or Modified-X, but less so for pipeline issues.

cmungall avatar Mar 01 '19 07:03 cmungall

+1 for a manageable set

drseb avatar Mar 01 '19 07:03 drseb

I'm not sure if this feature allows auto-assigning people

couldn't we just mention the right people/teams via the @ - notation?

drseb avatar Mar 01 '19 07:03 drseb

I am happy for manageable :P It might have been a bit of an egoistic suggestion, because I keep having to delete the term request blurp on all the ontologies I interact with. But maybe that is not so bad. Keep it short! :)

matentzn avatar Mar 04 '19 10:03 matentzn

  • Adding term
  • Adding synonym
  • Subclass revision
  • Logical definition revision
  • Textual definition revision
  • Obsoletion

Before these get made into the issue types, I suggest using consistent phrasing:

  • Add term
  • Add synonym
  • Revise subclass
  • Revise logical definition
  • Revise textual definition
  • Obsolete a term

nlharris avatar Mar 08 '19 00:03 nlharris

@pnrobinson @cmungall we have now implemented this in HPO. thanks @nlharris for the suggestions

drseb avatar Mar 20 '19 19:03 drseb

see https://github.com/obophenotype/human-phenotype-ontology/issues/new/choose

drseb avatar Mar 20 '19 19:03 drseb

very nice! :-0

pnrobinson avatar Mar 20 '19 19:03 pnrobinson

Hi all, good stuff. I'll be implementing these in ENVO.

I'm with @nlharris on consisting phrasing and prefer the imperative tone:

Add term Add synonym Revise subclass Revise logical definition Revise textual definition Obsolete a term

I'd also suggest we have some general types:

  • Revise annotation properties
  • Revise axioms

The axiom type could be added on to the logical def type:

  • Revision logical definition or axiomatisation

pbuttigieg avatar Mar 20 '19 20:03 pbuttigieg

nice!

On Wed, Mar 20, 2019 at 12:20 PM Sebastian Köhler [email protected] wrote:

see https://github.com/obophenotype/human-phenotype-ontology/issues/new/choose

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/INCATools/ontology-development-kit/issues/162#issuecomment-474991308, or mute the thread https://github.com/notifications/unsubscribe-auth/AADGOXRkD0TL1Pnilk73s-lb16dx892Dks5vYon2gaJpZM4ahxrO .

cmungall avatar Mar 20 '19 20:03 cmungall

Hi all,

just wanted to let you know that it gets even cooler. You can automatically assign people and automatically assign labels in the templates. See here how to do it and click somewhere here to see it in action.

Best, Seb

drseb avatar Mar 21 '19 07:03 drseb

ooooh, awesome!!

On Thu, Mar 21, 2019 at 12:52 AM Sebastian Köhler [email protected] wrote:

Hi all,

just wanted to let you know that it gets even cooler. You can automatically assign people and automatically assign labels in the templates. See here https://github.com/obophenotype/human-phenotype-ontology/tree/master/.github/ISSUE_TEMPLATE how to do it and click somewhere here https://github.com/obophenotype/human-phenotype-ontology/issues/new/choose to see it in action.

Best, Seb

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/INCATools/ontology-development-kit/issues/162#issuecomment-475137923, or mute the thread https://github.com/notifications/unsubscribe-auth/AADGOe0KE2vzueHHibGunjVL1Ncl3HyVks5vYzowgaJpZM4ahxrO .

cmungall avatar Mar 22 '19 18:03 cmungall

btw: this is an excellent opportunity to standardize on the use of github labels across repos.

For example, if we standardize on "obsolete" then we can do a cross-repo search:

https://github.com/search?q=label%3A%22obsolete%22

(so far this just returns GO, but @drseb has introduced this for HPO)

cmungall avatar Apr 16 '19 18:04 cmungall

btw: this is an excellent opportunity to standardize on the use of github labels across repos.

+1

pbuttigieg avatar May 05 '19 18:05 pbuttigieg