ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

T&A 44644: Adds tiny post fix for taxonomy filtering issue in question pool table

Open matheuszych opened this issue 9 months ago • 6 comments

Mantis: 44644

This pull request provides a tiny addition to the original fix. While porting the fix to newer versions i discovered an issue. The original fix did not work if you had no taxonomies in your question pool. The additional check should take care of that.

matheuszych avatar Mar 31 '25 13:03 matheuszych

Already reviewed by @thojou.

matheuszych avatar Mar 31 '25 13:03 matheuszych

Hi @tfamula & @Amstutz I think this is a follow-up to #9223.

dsstrassner avatar Apr 01 '25 10:04 dsstrassner

@tfamula can you look into this and give a recommendation for or against merging?

Amstutz avatar Apr 07 '25 12:04 Amstutz

LGTM!

tfamula avatar Apr 07 '25 13:04 tfamula

@matheuszych I would merge this, but I wonder why the tests fail now. Could you look into this please?

klees avatar Apr 11 '25 10:04 klees

@matheuszych please assign back to us when done.

Amstutz avatar Apr 22 '25 07:04 Amstutz

Hello @klees

this PR is now done and can be reviewed/merged.

Best regards, @matheuszych

matheuszych avatar Aug 14 '25 09:08 matheuszych

Thanks @matheuszych!

klees avatar Sep 17 '25 07:09 klees