ILIAS-eLearning
Fix page editor plugin export in T&A
See https://mantis.ilias.de/view.php?id=44719
This pull request solves the issue by providing the handling of page editor plugins from the COPage service also in the Test and TestQuestionPool components.
To avoid code duplication, functions from ilCOPageExporter and ilCOPageImporter are moved to a new class ilPageComponentPluginExportImportStore, which is used by the export and import in the CoPage, TestQuestionPool and Test components.
The static functions provided in ilPageComponentPluginExporter and ilPageComponentPluginImporter are rewritten to use the new class as a store, but currently they must be kept for compatibility with existing plugins.
@alex40724 As far as I understood @kergomard in the TA Tech Squad, he would accept the changes in T&A if you accept them for the COPage service. Could you have a look?
I remove my assignment here. Please add me again, if there is anything I will need to do.
Best, @kergomard
@fneumann Thanks for the PR and sorry for the delay. I had a second look at the code today. It all looks feasible, but it is too much code to tell, if everything works as expected without doing detailed tests with real data. I did not have the time for this yet.
Hi @alex40724
Thanks for your reply. For ILIAS 9 I built a workaround in the plugin https://github.com/DatabayAG/PCLimitedMediaPlayer, and I hope that will work in ILIAS10, too. I can rewrite the PR for ILIAS 11 to give you more time for testing and without the danger of affecting productive instances yet.
Thank you @alex40724 for the acceptance. Meanwhile, we found an ugly solution for our plugin in ILIAS 9 and 10 by overloading a core class. So at the moment there is no need to risk any problem in the production branches.
I propose to update this PR for the release branch of ILIAS 11 once it is created. Certainly, I volunteer to fix issues related to this change.
@kergomard would you agree with that procedure?