ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

[FIX] #44176 UI: add support for all `Field\File` metadata inputs.

Open thibsy opened this issue 11 months ago • 4 comments

Hi folks,

This PR fixes https://mantis.ilias.de/view.php?id=44176, by removing the mechanism that merged the Field\Hidden dynamic inputs template with existing nested inputs of Field\Group inputs provided for metadata. This leads to a change in behaviour when handling file uploads, where a metadata input is provided, because it will be nested an additional time now. I have also decided not ti map the file-id value to the Field\UploadHandler::getFileIdentifierParameterName() key anymore, since this was only necessary because due to the merger of said inputs.

@chfsx this PR also contains a commit to address the changed behaviour in file upload handling. The ilObjFile was the only place where I could find usages of the Field\File input with a metadata input.

Kind regards, @thibsy

thibsy avatar Feb 13 '25 14:02 thibsy

The pipelines are failing because they are currently broken in trunk.

thibsy avatar Feb 14 '25 09:02 thibsy

@Amstutz this was intentional, but if all others display a result, I can add this to the example as well.

thibsy avatar May 09 '25 08:05 thibsy

@thibsy I do not have a strong opinion for one or the other.

Just one thing:

  • [x] Clear description: The human readable description of the example that is pushed to testrail must make it obvious for the tester, what the example is supposed to do. Feel free to adapt the description or the example itself, as long as it is immediately clear, what the intended behavior is, we are fine.

thx.

Amstutz avatar May 09 '25 12:05 Amstutz

@Amstutz done. Pipeline fail due to a wrong copyright check, see #9554

thibsy avatar May 13 '25 05:05 thibsy

Merged with #7339

thibsy avatar Sep 23 '25 12:09 thibsy