ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

Bugfix: 42377 & 42369: UI/Fields: Fix undefined input in file inputs

Open lukas-heinrich opened this issue 1 year ago • 2 comments

This PR fixes an issue caused by #8177 which means that the id of the input field can no longer be accessed. I fixed the issue by using the id of the associated fieldset element as described in the PR.

I am looking forward to feedback or hints if it can be implemented differently.

lukas-heinrich avatar Oct 23 '24 12:10 lukas-heinrich

Hi all

I assigned you all, because I was unsure if it was the ui-coordinators or @chfsx who felt responsible for this.

You were just a little bit quicker than me @lukas-heinrich ;-).

This has quite a few consequences:

  • Settings with new forms cannot be saved.
  • Imports don't work.

This would be the issue that triggered my look into it: https://mantis.ilias.de/view.php?id=42369

Thank you all and best, @kergomard

kergomard avatar Oct 23 '24 12:10 kergomard

T&A issue for this: https://mantis.ilias.de/view.php?id=42377

dsstrassner avatar Oct 23 '24 12:10 dsstrassner

@nhaagen Review this please.

Thanks @lukas-heinrich

klees avatar Oct 23 '24 13:10 klees

Hi @nhaagen !

Thank you for the feedback. This is of course an even simpler solution. I have customized the selector and tested it, it works as it should.

Thanks and best regards. @lukas-heinrich

lukas-heinrich avatar Oct 24 '24 06:10 lukas-heinrich

thx big time @lukas-heinrich and @kergomard as well as @nhaagen for the review!

Amstutz avatar Oct 24 '24 07:10 Amstutz