ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

Feature: New taxonomy filters to use taxonomies in the question selection for fixed tests

Open matheuszych opened this issue 1 year ago • 5 comments

This is the implentation of the Feature Wiki entry New taxonomy filters to use taxonomies in the question selection for fixed tests.

I believe all the requested features are implemented according to the Request.

Important!

The filtering of the data is dependent on this https://github.com/ILIAS-eLearning/ILIAS/pull/7940 PR.

matheuszych avatar Aug 15 '24 11:08 matheuszych

@thojou is this PR already reviewed by you and the customer? Please provide an "Abnahmeplattform" for me.

dsstrassner avatar Aug 29 '24 15:08 dsstrassner

Hey @dsstrassner,

I've reviewed the PR, and I believe the implementation is solid and well-structured.

Based on the Feature-Wiki, there is a slight divergence in the current implementation that we've already discussed with @oliversamoila. Specifically, the "Question Pool Title" field in the Filter and Table has been renamed to "Parent Object Title". This change was made because the related table is context-sensitive and can be used for adding questions either from 1. another question pool or 2. another test. In the second scenario, the label "Question Pool Title" wouldn't be appropriate.

An alternative approach could be to dynamically adjust the title based on context, switching between "Question Pool Title" and "Test Title" as needed.

We've already delivered this feature to @oliversamoila and provided an acceptance platform. @oliversamoila will inform the relevant customers.

This PR is ready for further review. Perhaps @klees or @mjansenDatabay could take a look to ensure we're avoiding any potential anti-patterns.

thojou avatar Sep 02 '24 13:09 thojou

Hey @dsstrassner I'll contact you and Tomke as soon as possible.

Best regards Oliver

oliversamoila avatar Sep 02 '24 13:09 oliversamoila

Test installation is rebased, therefor new objects will be possible. @dsstrassner will look into it, as soon as possible.

dsstrassner avatar Sep 19 '24 08:09 dsstrassner

Hi @dsstrassner,

The bulk-action "For Entire Table" now respects the applied filters and executes the command on all filtered items.

As for the issue with optional filters, I've already created a Mantis ticket for it: #42109.

I believe we can proceed from here.

Best regards,

thojou avatar Oct 23 '24 13:10 thojou

@kergomard Due to some git issues please continue to https://github.com/ILIAS-eLearning/ILIAS/pull/8264.

matheuszych avatar Oct 25 '24 13:10 matheuszych