ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

T&A 40791: Superglobals replacement in Test component

Open matheuszych opened this issue 1 year ago • 5 comments

Superglobal variables such as $_GET or $_POST should not be accessed directly. Instead, use the request and refinery mechanisms. Currently, there are four instances where this change is not feasible due to limitations in the request and refinery systems, but these will be addressed in the future.

Mantis: 40791

matheuszych avatar Jul 12 '24 11:07 matheuszych

Is this internally reviewed by @thojou or @mbecker-databay? If so, I add @kergomard as a reviewer here on GitHub.

dsstrassner avatar Aug 29 '24 07:08 dsstrassner

@dsstrassner Yes, this PR has been reviewed internally.
@matheuszych As per this commit, the necessary changes to the RequestWrapper have been implemented, so there should be no blockers to proceed with refactoring the sections marked as TODO.

All other refactorings look good to me.
@kergomard Could you please take a look at the changes?

thojou avatar Aug 29 '24 13:08 thojou

@kergomard, @thojou

I addressed the minor issues you mentioned. Further I will look into using the RequestDataCollector (WIP).

matheuszych avatar Aug 30 '24 09:08 matheuszych

@kergomard, @thojou

@bidzanaaron and i implemented the requested changes regarding the RequestDataCollector. I believe this PR is ready for a rereview.

matheuszych avatar Sep 10 '24 07:09 matheuszych

@thojou will review internally and @kergomard could approve afterward and merge.

dsstrassner avatar Sep 19 '24 08:09 dsstrassner

Ok, I close this as we have a new version here.

Thank you very much @matheuszych for pursuing this issue further.

kergomard avatar Nov 20 '24 17:11 kergomard