T&A 40791: Superglobals replacement in Test component
Superglobal variables such as $_GET or $_POST should not be accessed directly. Instead, use the request and refinery mechanisms. Currently, there are four instances where this change is not feasible due to limitations in the request and refinery systems, but these will be addressed in the future.
Is this internally reviewed by @thojou or @mbecker-databay? If so, I add @kergomard as a reviewer here on GitHub.
@dsstrassner Yes, this PR has been reviewed internally.
@matheuszych As per this commit, the necessary changes to the RequestWrapper have been implemented, so there should be no blockers to proceed with refactoring the sections marked as TODO.
All other refactorings look good to me.
@kergomard Could you please take a look at the changes?
@kergomard, @thojou
I addressed the minor issues you mentioned. Further I will look into using the RequestDataCollector (WIP).
@kergomard, @thojou
@bidzanaaron and i implemented the requested changes regarding the RequestDataCollector. I believe this PR is ready for a rereview.
@thojou will review internally and @kergomard could approve afterward and merge.
Ok, I close this as we have a new version here.
Thank you very much @matheuszych for pursuing this issue further.