ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

T&A 41611: Fix regex for gaps in cloze questions in learning modules

Open malaja11 opened this issue 1 year ago • 5 comments

https://mantis.ilias.de/view.php?id=41611

As suggested, I replaced the old regex with the one used for cloze questions in Tests.

cc @thojou

malaja11 avatar Jul 05 '24 06:07 malaja11

Is also needed for ILIAS 8, according to the mantis report.

dsstrassner avatar Jul 08 '24 10:07 dsstrassner

Hey @Uwe-Kohnle,

@malaja11's changes are in the Scorm2004 Module. Could you please check if we can adjust the regex as proposed?

Thanks so much!

thojou avatar Jul 10 '24 09:07 thojou

Hi @Uwe-Kohnle, any updates on this?

dsstrassner avatar Aug 29 '24 07:08 dsstrassner

Hi @Uwe-Kohnle, is there any chance, that you Merge or at least accept this PR until the next JourFixe on September 16th?

dsstrassner avatar Sep 10 '24 10:09 dsstrassner

@Uwe-Kohnle We will merge this end of the week. Okay?

dsstrassner avatar Sep 19 '24 08:09 dsstrassner

Hi all, any news on this? Is there any issue, why this can't be merged?

iljalukin avatar Dec 12 '24 12:12 iljalukin

hi @malaja11 & @thojou maybe the conflicts could be quick resolved and afterwards the PR merged?

dsstrassner avatar Dec 12 '24 12:12 dsstrassner

Hi @dsstrassner I resolved the conflict

malaja11 avatar Dec 12 '24 12:12 malaja11

Hey @malaja11,

thanks for resolving the conflicts. I've finally merged the changes into release_9 and also cherry-picked them into release_10 and trunk.

Best, @thojou

thojou avatar Dec 12 '24 13:12 thojou

In Addition, i also cherry-picked the changes backwards to release_8.

thojou avatar Dec 12 '24 13:12 thojou

Thanks @malaja11 & @thojou!

dsstrassner avatar Dec 12 '24 13:12 dsstrassner