ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

T&A 41605 Fix HTML escaping for single-line question answers

Open thojou opened this issue 1 year ago • 3 comments

This PR addresses the issue reported in https://mantis.ilias.de/view.php?id=41605.

Previously, HTML escaping was applied to resolve https://mantis.ilias.de/view.php?id=36167, which removed all HTML tags from answer text. This commit updates the behavior to retain HTML tags in single-line answers unless the answer type has changed or the answer is in multiline mode. Additionally, it fixes an issue encountered after importing a question pool with single-choice questions using multiline answers. The system did not correctly detect the edit mode and displayed a multiline answer as a single-line input field containing all tags. This bug was reported by @dsstrassner. I was able to reproduce and fix it, though I could not find a related Mantis ticket.

This PR also introduces some deprecations on methods, which will be reworked or removed in ILIAS 10. These changes can be cherry-picked into release_9. For the trunk, I will prepare a separate PR to remove the deprecations and make further adjustments.

thojou avatar Jun 28 '24 13:06 thojou

Hi @tjoussen, I'm fine with this approach. Please go ahead.

dsstrassner avatar Jul 02 '24 08:07 dsstrassner

Hi @klees could you please review this PR?

dsstrassner avatar Aug 29 '24 07:08 dsstrassner

@thojou need to rename the trait and afterward the PR is ready to merge.

dsstrassner avatar Sep 19 '24 08:09 dsstrassner

hi @thojou Any Updates on this?

dsstrassner avatar Nov 29 '24 10:11 dsstrassner

Hi @thojou, ILIAS 8 is out of maintenance and in the security phase. I close the corresponding Mantis Report and this PR.

dsstrassner avatar Jan 10 '25 08:01 dsstrassner