ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

fix some functoins if optional parameters are omitted

Open ingoj opened this issue 1 year ago • 3 comments

in some functions, $user and $types should be optional parameters. in ILIAS 8 (and posibly 9/trunk) these parameters must be supplied, but the function itself contains checks for these paramaters. This PR contains a possible, but untested fix.

ingoj avatar Jun 06 '24 15:06 ingoj

Mantis ID: 41487

ingoj avatar Jun 06 '24 16:06 ingoj

@ingoj, Can you add the parameter signatures to inc.soap_functions.php? Without such adjustments there would be a type error

jeph864 avatar Oct 17 '24 10:10 jeph864

@jeph864, I updated inc.soap_functions.php accordingly, I hope everything is fine now. Sorry I could not test the changes.

ingoj avatar Oct 17 '24 15:10 ingoj

@ingoj , thanks for the PR

jeph864 avatar Nov 29 '24 16:11 jeph864