Abandon Session Mode «Load-Dependent Session Settings»

[mBeym]

Removes everything related to the load-dependent session settings

Feature Wiki Page: https://docu.ilias.de/goto_docu_wiki_wpage_8263_1357.html

• @Uwe-Kohnle: We had to change one line in the SCORM components
• @kergomard: We removed the "Session Mode" setting from the user component

A quick review is highly appreciated.

[mjansenDatabay]

@mBeym Please resolve the conflicts

[mBeym]

@mBeym Please resolve the conflicts

done

[mjansenDatabay]

Thank you very much for the PR @mBeym and @mjansenDatabay !

I'm fine with the changes in ilObjUserFolderGUI.

If you need to touch this once more (and only then, as it is not important enough): Might I ask you to rename the $cb variable here. I know, it was called $cb, but I don't care much about it being a checkbox, I would like to know what it actually sets ;-). Maybe something like ($session_reminder_cb or so).

And a very small suggestion: Shouldn't we maybe drop the old settings through a db-update-step? I know, I'm a stickler for detail, but if for any reason you need to go through the settings table all old clutter just, well, clutters things up.

Thanks again and best, @kergomard

Thx @kergomard , the old settings should be deleted here: https://github.com/ILIAS-eLearning/ILIAS/pull/7525/files#diff-8b1ca2c61f7661b03b2012f2337b9baba324b4eb4ebb25c5128b3ea40f55d72aR37

@mBeym Can you please rename the variable?

[kergomard]

Thank you very much for the pointer @mjansenDatabay ! Sorry for not having read carefully enough (one should not collapse the files overview and forget one has done so)!

[mBeym]

Thank you very much for the PR @mBeym and @mjansenDatabay ! I'm fine with the changes in ilObjUserFolderGUI. If you need to touch this once more (and only then, as it is not important enough): Might I ask you to rename the $cb variable here. I know, it was called $cb, but I don't care much about it being a checkbox, I would like to know what it actually sets ;-). Maybe something like ($session_reminder_cb or so). And a very small suggestion: Shouldn't we maybe drop the old settings through a db-update-step? I know, I'm a stickler for detail, but if for any reason you need to go through the settings table all old clutter just, well, clutters things up. Thanks again and best, @kergomard

Thx @kergomard , the old settings should be deleted here: https://github.com/ILIAS-eLearning/ILIAS/pull/7525/files#diff-8b1ca2c61f7661b03b2012f2337b9baba324b4eb4ebb25c5128b3ea40f55d72aR37

@mBeym Can you please rename the variable?

Done. Renamed to $session_reminder.

@kergomard I also renamed the $ti ilNonEditableValueGUI variable to $session_config if that's ok for you?

[mjansenDatabay]

Hi @pascalseeland ,

I would like to merge this within the next week. Any feedback is highly appreciated.

Best regards, Michael