ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

0040628: Course Links require Read Access to Target Course

Open nmatuschek opened this issue 11 months ago • 2 comments

This PR is for ticket: https://mantis.ilias.de/view.php?id=40628

nmatuschek avatar Mar 13 '24 09:03 nmatuschek

Hi @smeyer-ilias , any feedback on this topic?

fsesterh avatar May 22 '24 13:05 fsesterh

Hi @nmatuschek

Thanks for providing a PR for this issue.

Please answer the following questions:

  • [x] Why having a whole new class to tackle this, couldn't we just add a configure option to ilRepositorySelector2InputGUI which permission to check (read/visible)? I suspect the resulting code change would be much smaller.

Please implement the following changes:

  • [x] Please add a configure option for ilRepositorySelector2InputGUI unless there is a very good reason not to do so. We should have less code and make the option available for other contexts as well.

kindly, @alex40724

alex40724 avatar Jun 11 '24 13:06 alex40724