Block Removal of obsolete Code regarding old rendering

[fhelfer]

Since old getHTML has been abandoned and force switched to getHTMLNew() for all Blocks, the old code fragments scattered in various components can be deleted.

[Amstutz]

I love this part:

[nicoroeser]

Thank you, @fhelfer, for your work on this! And thanks for putting the changes to the file headers in a separate commit. :smiley:

Let’s take this pull request further and prevent it from gathering dust. So far, I have assigned everyone as a reviewer who is responsible for changed code. Please have a look and give your go or raise objections.

Remember that the changes will most probably be also needed on trunk; tree structure has changed a bit there.

Anyone who likes to take the pull request on and merge the changes after the reviews?

Even though I don’t claim to understand all that’s going on here, just two comments from me:

1. While I understand what the change to Services/Dashboard/ItemsBlock/classes/class.ilDashboardSidePanelSettingsRepository.php does, I cannot directly see why it is introduced. In case it is not directly related to the rest of the commit, I’d recommend to split the part out and explain it in the commit message.
2. Services/Dashboard/classes/class.ilDashboardContentBlockGUI.php still contains a function fillDataSection, which I think is not used anymore. Is this an oversight or is the function required?

Fellow developers will know far better than me whether these things are issues or not.

[iszmais]

Hello,

Let’s take this pull request further and prevent it from gathering dust.

To clean off the dust of this, I would encourage all affected authorities to give their approval for their components (if not already happened). Be aware that your approval is only necessary for changes inside your component and not the entire PR:

Therefore, the following approval is still open:

• @schmitz-ilias for Poll
• @klees for StudyProgramme
• @mjansenDatabay for Mail
• @smeyer-ilias for Search

Further, I want to encourage any authority to take a look at one (or all) of the components without authority and give their approval:

• Block
• Container
• InfoScreen

I will happily await any feedback on those components until 29.08.2024 to give any interest enough time to consider a participation. To keep the ball rolling after that, @gvollbach and I will take care of this PR then.

Greetings, @iszmais

[iszmais]

Thx, @smeyer-ilias but the credit actually goes to @fhelfer :D

@fhelfer can you adapt the last small change requests (Poll: dublicated type strict and Calendar: remove template). With that im confident this can be merged as soons as a shepherds is set.

Greetings, @iszmais

[mjansenDatabay]

@iszmais / @fhelfer I guess further templates can be removed, not only tpl.pd_event_list.html.