ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

NPM/Chatroom: Add `mysql`

Open mjansenDatabay opened this issue 1 year ago • 3 comments

This PR adds mysql as NPM dependency for the chatroom

Usage:

  • components/ILIAS/Chatroom/chat/Persistence/Database.js

Wrapped By:

  • Database (see: components/ILIAS/Chatroom/chat/Persistence/Database.js)

Reasoning:

  • mysql is a mysql driver for Node.js. It is used to communicate with a mysql (or mariadb) server.

Maintenance:

  • mysql has a lot of contributions. However, the last activity is from 2022. This could be a potential risk for new releases of Node.js in the future or potential security issues. If we could not rely on this library anymore, we will have to check if there are good alternatives, or we will have to switch to an API based approach on the ILIAS side instead of using a direct database connection.

Links:

  • NPM: https://www.npmjs.com/package/mysql
  • GitHub: https://github.com/mysqljs/mysql
  • Documentation: https://github.com/mysqljs/mysql#readme

mjansenDatabay avatar Dec 11 '23 09:12 mjansenDatabay

JourFixe, 11 DEC 2023: Dependency is accepted for trunk but needs to be monitored.

matthiaskunkel avatar Dec 11 '23 13:12 matthiaskunkel

Hello @mjansenDatabay ,

I am currently creating an PR via cherry-pick with all dependencies approved in the JF in december 2023. Sadly I can't include your npm mysql PR because the included package is wrong. You included node-uuid instead of mysql.

Kind regards Luka

lukastocker avatar Feb 26 '24 13:02 lukastocker

Hello @lukastocker ,

I fixed the dependency.

Best regards Michael

mjansenDatabay avatar Feb 26 '24 15:02 mjansenDatabay

This should have become part of ILIAS 10 via this PR. As always, something might have gone wrong. If you are still missing that package, please ping me.

Kind regards!

klees avatar Jul 09 '24 11:07 klees