ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

Update headlines.md fixed typo issues

Open SaiAryan1784 opened this issue 1 year ago • 4 comments

SaiAryan1784 avatar Oct 31 '23 10:10 SaiAryan1784

Hi @acgruber may I assign this to you? The changes should be done in other branches (especially release_9 and trunk) as well.

chfsx avatar Oct 31 '23 12:10 chfsx

Hi @acgruber ,

this PR has been lying around for quite a while. Was it okay to assign the pull request to you?

Thanks and best, @mjansenDatabay

mjansenDatabay avatar Mar 05 '24 12:03 mjansenDatabay

Hi @mjansenDatabay,

Please excuse me somehow missing this notification. I will look into it asap. Thanks for the reminder!

Cheers @acgruber

acgruber avatar Mar 05 '24 14:03 acgruber

Hi @mjansenDatabay & @chfsx , This PR is ready to merge. Before I proceed: Is there a way to simultaneously add the changes to 9 and trunk or do I have to go for two additional PRs? Thanks and cheers!

acgruber avatar Mar 06 '24 10:03 acgruber

@acgruber

Is there a way to simultaneously add the changes to 9 and trunk or do I have to go for two additional PRs?

Usually the maintainer is responsible to integrate the changes into the other release branches. AFAIK you don't have the permission to push to our repositories, right?

IMO we have two options: Option 1) You create new PRs for the other release branches. Option 2) Soneone cherry-picks the changes to the other release branches and pushes the commit without creation new PRs. I could do this for you.

mjansenDatabay avatar Mar 14 '24 12:03 mjansenDatabay

Thanks for the feedback, @mjansenDatabay! Let's go for option 2 then :) And should I merge this PR now or would you prefer to do this as well?

acgruber avatar Mar 14 '24 15:03 acgruber

@acgruber Yes, please merge the PR. I pick the commit to the other branches afterwards.

mjansenDatabay avatar Mar 15 '24 08:03 mjansenDatabay

Thanks to @SaiAryan1784 for the improvement. Merged to Release_8. Will be cherry-picked to other branches as well.

acgruber avatar Mar 15 '24 09:03 acgruber

Picked!

mjansenDatabay avatar Mar 15 '24 11:03 mjansenDatabay