UI/standalone view controls/sortation/26634

[nhaagen]

https://mantis.ilias.de/view.php?id=26634

This decouples ViewControl Sortation from Dropdown, so an item my be shown as "selected". Please refer to the ticket, especially @yvseiler 's last comment.

[oliversamoila]

Good morning to you, @nhaagen and @klees. Can you briefly help me to understand the status correctly? There is no reviewer assigned at the moment, would that have to be done in the next step or is something else required first? Thank you very much for this work!

[klees]

Hi @oliversamoila,

this just didn't move up to the top of my priority list until now. @Amstutz, @thibsy and me agreed that I'll do an internal QA for the code of my colleagues before I pass this on for a UI coordinator review.

Best wishes!

[nhaagen]

Hi @klees, I left ::withSelected; the idea was to (pre-)factor the control and then set the value. Although all the places I saw use the constructor over the mutator, I'd really like to keep the option. There are checks in place, too ;)

[nhaagen]

rebased to trunk...

[oliversamoila]

A really quiet ping. We would like to integrate this at least in the dashboard for the release 9. Can you give us a realistic time frame? Thank you very much.

[nhaagen]

rebased to trunk

[klees]

@nhaagen Please rebase to release_9 again. We need it there...

[klees]

@thibsy @Amstutz Would you be so kind and look into this?

[nhaagen]

Hi @thibsy , thanks for your comments. Let's head over to #7136, though, and close this.

I fixed the Factory's signature and the Test (thanks).

• [ ] C\ViewControl (namespace): this PR raises the question again, what we should do with this namespace. This is more of an observation than a direct question, it does not need your response. However, you are most likely fixing an issue here which also exists in the new implementation (C\Input\ViewControl\Sortation), which is why we will not close the related mantis ticket. This issue will reappear when consumers start using the new approach.

This is true. The Components are becoming more and more different, and I'd really like to ditch these here. However, the selected-tick is implemented in the Input/ViewControl/Sortation as well.

• [ ] sortation.js: why are there two different versions of this file (internal and public), and why is it necessary at all? It does not seem to be required anywhere. Maybe something went wrong when rebasing the changes?

Sorry, that's a glitch. sortation.js is removed in #7136.

• [ ] examples\ViewControls\Sortation\small: why did you remove this example? I assume this example would still be applicable, to e.g. showcase how labels may be omitted for limited space, as it is described on the factory. Could you adjust the example instead?

Good observation, thanks again, a little embarassing for me. Fact is, with the proposed implementation, this would simply not work anymore. I therefore added ::withHiddenLabel and reinstated the small-example.

All changes are in #7136.

Best regards, Nils