ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

Published 20 hours ago • verified publisher icon ILIAS-eLearning

UI: Abandoning FileRemovalURL

Open tbongers-cat opened this issue 1 year ago • 10 comments

This PR removes getFileRemovalURL() and the associated getRemoveResult() from Input/Field/UploadHandler as well as their implementations, as proposed by @klees on #5807 and Mantis #37161. It also contains a small fix for the handling of withInput() on Dynamic Inputs.

tbongers-cat avatar May 15 '23 07:05 tbongers-cat

Hi Jour-Fixe,

as this is a breaking change in the release we should certainly discuss this in public. This is the solution @thibsy and me discussed.

Kind regards!

klees avatar May 15 '23 07:05 klees

@matthiaskunkel stated in Mantis Issue #37161:

Jour Fixe, 15 MAY 2023: Richard notified us about the problems of the assynchronuous deletion of files in the KS File Input component and suggests to remove this feature with ILIAS 8. We accept this changing break for ILIAS 8. A related PR is already available.

So, the JF label is now done, or is it?

dsstrassner avatar May 16 '23 06:05 dsstrassner

@thibsy / @chfsx Most of the changes are in code either maintained or initially created by you. Is it ok, if I assign you to manage this PR?

klees avatar May 16 '23 09:05 klees

Added two small fixes in IASS and Navigation that came up during testing (see commits)

tbongers-cat avatar May 16 '23 09:05 tbongers-cat

Hi @tfamula,

there are some changes in the Skill-Service, I think you will want to have a look.

Kind regards!

klees avatar May 16 '23 09:05 klees

Hi @kergomard,

there are some changes in Services/Object, I think you will want to have a look into this.

Kind regards!

klees avatar May 16 '23 09:05 klees

Hi @chfsx and @thibsy I found thiswhen looking at the older PRs for the TB. I think this could be rebased and merged, right, as it has all the necessary reviews?

Thank you very much and best, @kergomard

kergomard avatar Nov 14 '23 06:11 kergomard

Hello everyone, Is there any news here? The problem initially described in https://mantis.ilias.de/view.php?id=37161 is now occurring more frequently due to its increasing popularity.

Thank you very much. Oliver

oliversamoila avatar Jan 30 '24 07:01 oliversamoila

Sorry about the delay, I totally lost track of this. The branch has now been rebased and the target set to 'release_9'.

tbongers-cat avatar Jan 31 '24 10:01 tbongers-cat

I commented in the related ticket: https://mantis.ilias.de/view.php?id=37161#c100870

chfsx avatar Feb 01 '24 10:02 chfsx