ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

Published 20 hours ago • verified publisher icon ILIAS-eLearning

0029975 failed test online status

Open kunzeus opened this issue 2 years ago • 2 comments

Hello

This PR should fix the bug presented in: https://mantis.ilias.de/view.php?id=29975 It changes the default import behavior of ilTestObjects. Instead of defaulting to online it now uses the online/offline-state set by the ilContainerImporter. It also fixes what, I believe, is a bug in the ilContainerImporter, at least in my test instance. The bug set other object lm, crs, grp etc. to online after the import, ignoring the online/offline-state of the imported XML file. With the proposed fix, the online/offline-state of the imported XML file is used for container imports.

I'm still learning ILIAS, so please let me know: if anything slipped my attention, or what can be improved further.

kunzeus avatar Oct 10 '22 11:10 kunzeus

Hi @alex40724

I assign you also, since @kunzeus want to change Services/Container/classes/class.ilContainerImporter.php

dsstrassner avatar Oct 10 '22 12:10 dsstrassner

@smeyer-ilias Could you have a look at the changes of your code in the ContainerImporter, please.

alex40724 avatar Oct 10 '22 13:10 alex40724

@smeyer-ilias : Could you please have a look at the part that concenes you?

kergomard avatar Oct 25 '22 04:10 kergomard

Dear JourFixe,

how should we proceed?

dsstrassner avatar Jan 04 '23 13:01 dsstrassner

Jour Fixe, 09 JAN 2023: PM will contact @smeyer-ilias and ask for feedback.

matthiaskunkel avatar Jan 09 '23 12:01 matthiaskunkel

Dear JF, I like to inform you all, that as there is no reaction occurred, so @mbecker-databay or @kergomard will merge this PR accordingly in the next days.

dsstrassner avatar Jan 23 '23 09:01 dsstrassner

Thanks @kunzeus for fixing this. Your changes streamline the online / offline handling for imported objects using the centralized offline handling from ilObject. Objects which do not use that offline handline might still set a wrong status.

Since this is tagged with the Jour-Fixe label, i want to ask whether it is really necessary to always import question pools with status "online".

smeyer-ilias avatar Jan 23 '23 11:01 smeyer-ilias

Jour Fixe, 23 JAN 2023: We highly appreciate this PR and accept it for ILIAS 6 and newer versions. We do not see any reason to set question pools always online. We prefer the behaviour described by the new import where only the parent object (e.g. course) is set offline and all embedded object keep their status (online or offline).

matthiaskunkel avatar Jan 23 '23 12:01 matthiaskunkel

Hello,

@smeyer-ilias Currently, the Test Question Pool Object is not supporting offline Handling. Thereby, no offline state is written into the XML Export. But as far as I can say, changing this requires at least a DB update step (il_object_def: id:qpl, offline_handling:0->1) + other modifications to fit into the supporting offline handling category. I don't know what is required to support offline handling, and I would shelf it since it's not part of the fix this PR is about.

So it's either online or offline for all Question Pool imports in the meantime. However, I would address the issue in the next T&A TechSquad meeting.

kunzeus avatar Jan 24 '23 17:01 kunzeus