ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

TA: Repo for ScoreSettings, UI Form

Open nhaagen opened this issue 2 years ago • 3 comments

This adjusts the ResultSettings form of TestObject according to a suggestion from the ILIAS-NRW group. I still need some clarification concerning the exact mapping of some former options to new fields, but this should be a rather non-tech issue. Also, UI-forms are used as well as a repo-adaption to maybe devide the big number of settings into smaller units. I'll still have to look into export/import and the template-funtionality.

Comments are most welcome already, though.

nhaagen avatar Sep 05 '22 09:09 nhaagen

https://mantis.ilias.de/view.php?id=33680

dsstrassner avatar Sep 08 '22 09:09 dsstrassner

From TA TechSquad today(22.09.22): the recalculation of results is still necessary, and this PRs lacks the possibility; it will have to be amended.

nhaagen avatar Sep 22 '22 09:09 nhaagen

@nhaagen will finish the work on this PR after his return.

dsstrassner avatar Oct 13 '22 09:10 dsstrassner

Update: There are still some issues which should be addressed ;)

dsstrassner avatar Nov 09 '22 15:11 dsstrassner

When the issue of showing the icons in the "Review of Scored Answers" Subtab is gone, this PR is good to go from my perspective. If the PM decides to change the label from "Review of Scored Answers" to another one, this could be taken care of in the aftermath.

@klees has requested changes. I can't say, if where are finished on this or if there is anything left, at least a comment or so.

dsstrassner avatar Nov 23 '22 09:11 dsstrassner

From my perspective we are good to go, to merge this with ILIAS 8 and Trunk.

@mbecker-databay or @kergomard would someone of you two be so nice, to merge this accordingly?

dsstrassner avatar Nov 28 '22 08:11 dsstrassner

Thanks, @kergomard, for checking. For now, I removed this merge: https://github.com/nhaagen/ILIAS/pull/43 I'll add it later as PR to be discussed seperatedly.

nhaagen avatar Dec 12 '22 10:12 nhaagen

Thank you very much @nhaagen for all the work and for hugely improving these settings. As it was decided to port this back to ILIAS 8 we merge it at this late stage.

kergomard avatar Dec 12 '22 17:12 kergomard