ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

Published 20 hours ago • verified publisher icon ILIAS-eLearning

CSS: Fix Big in LPG of Learning Modules, see #34163 and #34163

Open Amstutz opened this issue 2 years ago • 2 comments

Proposed fix for https://mantis.ilias.de/view.php?id=34163 and https://mantis.ilias.de/view.php?id=34161

Note that the alt text has been left empty, since we probably might consider the icons here as "decorative" since an title in plain text is given as well.

Amstutz avatar Sep 01 '22 08:09 Amstutz

Note, the failing checks are only the copyright checks.

Amstutz avatar Sep 02 '22 12:09 Amstutz

@alex40724 why do you ignore my PR and "fix" this by using some ilIcon class, eventhough I asked you multiple times not to this and use the Standard Icon instead. Please revert your change above and consider this PR. thx.

Amstutz avatar Oct 04 '22 19:10 Amstutz

@Amstutz Personally I will not do refactorings by bug fixing. The migration to KS elements ends with beginning of beta to me, except in rare cases I will not introduce KS elements after this point.

The changes I did where predominantly to keep test cases from being usable, since Stefan was on vacation.

But Stefan is maintaining Services/Tracking anyway, so he will decide in this case.

alex40724 avatar Oct 16 '22 15:10 alex40724