ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

Fix for creating repository objects with long titles or descriptions

Open schmitz-ilias opened this issue 2 years ago • 3 comments

This PR fixes the creation of repository objects with titles and/or descriptions longer than object_data allows, see 33865.

schmitz-ilias avatar Aug 19 '22 08:08 schmitz-ilias

Hi @schmitz-ilias and everyone,

we discussed this PR in the TB today. Currently we cannot see anyone assuming responsibility for Service/Utilities as maintainer or coordinator, only implicit maintainers. On the other hand, almost every ILIAS developer seems to dependent on this somehow. This is why we decided to take this to the JF to find someone to look into this PR.

In general we are looking to get rid of Service/Utilities completely. There is valuable code in there, but there also seems to be stuff that is not (much) used anymore. The code that is still in use should migrate to newer facilities, such as src\Data, the Refinery or the UI-Framework. We ask every developer to participate in this endeavour so we won't need to ask the question "who is responsible for Services/Utilities again some times soon.

Best regards!

klees avatar Aug 23 '22 14:08 klees

Just my 2cents as an implicit maintainer. I think the length correction is ok. However I would not introduce strict type declaration during beta phase, since this might trigger additional errors in consumer code, which might have already been tested.

Done, thanks!

schmitz-ilias avatar Sep 07 '22 06:09 schmitz-ilias

Jour Fixe, 19 SEP 2022 : We highly appreciate this PR and accept it for 8 and trunk.

matthiaskunkel avatar Sep 19 '22 14:09 matthiaskunkel