ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

Add kitchen sink element: LightboxCardDetailPage

Open lscharmer opened this issue 2 years ago • 0 comments

This PR adds a new element LightboxCardDetailPage to the UI Framework. For the Feature Wiki: https://docu.ilias.de/goto_docu_wiki_wpage_5563_1357.html the currently available modal's do not satisfy the requirements for the proposed Feature. So this PR introduces a new lightbox modal which can be used to implement the feature in the future.

Why a new modal is needed:

The modal in the feature wiki can be implemented with existing modals like the RoundTrip or Lightbox + LightboxTextPage. The issue with the RoundTrip is that there must be 2 buttons and that it is intended to be used for a sequence of steps. For the previously named feature a roundtrip with a Close and an Add to profile button and a sequence of one step does imo not respect the intention of the roundtrip modal.

For the LightboxTextPage the description and rules seem to loosely match the purpose of the modal that should be implemented in the feature but imo it misuses the $text parameter, which also accepts HTML and which would violate (among other things) the dependence of HTML as an output stream and hides the actual structure that one wants to implement.

lscharmer avatar Aug 12 '22 13:08 lscharmer