ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

Possible Fix for Missing Info-Box After E-Mail-Confirmation

Open kergomard opened this issue 2 years ago • 1 comments

See: https://mantis.ilias.de/view.php?id=28383

Let me know if you would prefer another solution.

kergomard avatar Jul 27 '22 14:07 kergomard

I changed the assignment, since it these changes affect Services/Initialisation

smeyer-ilias avatar Jul 29 '22 10:07 smeyer-ilias

IMO this is only an issue for release_7. This seems to be fixed in the meantime for ILIAS >= 8.x.

mjansenDatabay avatar Jan 09 '23 08:01 mjansenDatabay

This solution differs from the (multiple) fixes in ILIAS >= 8.x (I am still not sure which appraoch I prefer :-)), but I'll accept this for release_7.

mjansenDatabay avatar Jan 09 '23 11:01 mjansenDatabay

@kergomard Could you please resolve the conflicts and rebase/force-push your branch afterwards?

mjansenDatabay avatar Jan 09 '23 11:01 mjansenDatabay

Thank you very much @mjansenDatabay for having a look at this. I rebased and force-pushed.

kergomard avatar Jan 09 '23 19:01 kergomard

@kergomard Thanks for that improvment! coincidentally i worked on the same problem yesterday i correlation of another Bug in ILIAS 8.

First comes first serves. I would revert my solution. Could you provide this fix for release_8 and trunk, too?

Greetings, @iszmais

iszmais avatar Jan 11 '23 11:01 iszmais

@iszmais , I'm now unsure: Do we need parts of this for trunk or not? I can provide a separate PR, if needed, no problem.

kergomard avatar Jan 11 '23 11:01 kergomard

@kergomard As far as i know the part wich provides the persistence of messages (so that they will not will be lost after deleting the session) is needed for 8 and trunk, therefore the first 3 additions of your PR.

I cant say anything for the other parts.

iszmais avatar Jan 11 '23 12:01 iszmais

But as i would assume and , as noone seem to have a veto on that, that this should be fully Cerry picked in ILIAS 8 and TRUNK.

iszmais avatar Feb 27 '23 13:02 iszmais