ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

Published 20 hours ago • verified publisher icon ILIAS-eLearning

Fix https://mantis.ilias.de/view.php?id=33523 (ILIAS 8 & Trunk)

Open kergomard opened this issue 2 years ago • 2 comments

This is a PR to discuss at the next TechSquad-Meeting.

Mantis Issue for ILIAS 7: https://mantis.ilias.de/view.php?id=33523

kergomard avatar Jul 24 '22 16:07 kergomard

@dsstrassner and I had a look at this and Denis decided we could change the implementation for ILIAS8 and Trunk. I propose an implementation fully based on INTs. I added quite a few controls for edge cases. I don't think they will happen often, but they might. A simpler solution is possible, if wanted. I added a test for this

kergomard avatar Aug 05 '22 08:08 kergomard

Hi @mbecker-databay,

this PR is open quite a long time. Is there anything left to discuss, or do you want anything changed? Also, https://mantis.ilias.de/view.php?id=33523 is marked as resolved, and you comment "PR is merged, thank you so much" but only #4851 is merged, which one resolves the problem in ILIAS 7. As I understand @kergomard right, this one is for ILIAS 8 and trunk!

dsstrassner avatar Oct 12 '22 08:10 dsstrassner

@kergomard will merge this for ILIAS 8 and cherry-pick for trunk. Also, he will add some notes to the Release Notes of ILIAS 8.0 as important changes. Dear @fwolf-ilias Please copy these notes also to the following Releases of ILIAS 8.1 and so on.

dsstrassner avatar Oct 27 '22 09:10 dsstrassner