ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

search: ctrl comment

Open smeyer-ilias opened this issue 3 years ago • 1 comments

It is not necessary to merge this PR. I only created it to discuss changes in ilCtrl.

The problem:

  • the main menu search creates a link to the "last search result" (./ilias.php?baseClass=ilSearchControllerGUI)
  • ilSearchController forwards to the last search presentation class (e.g ilLuceneSearchGUI, ilSearchGUI,...)
  • without the new (deprecated) call of setCmdClass() a ctrl error is triggered "ilCtrl cannot find a path for 'ilobjectcopygui' that reaches 'ilSearchControllerGUI'"

Prior releases of ilCtrl stored the "forward class" in ilCtrl->current_node, this seems to be not the case anymore.

I suspect that similar errors appear in other areas. E.g in the calendar service.

How do we proceed here?

smeyer-ilias avatar Jul 15 '22 09:07 smeyer-ilias

Hi @smeyer-ilias and thanks for opening this discussion!

I assume your GUI is able to create valid link targets to the corresponding (searched) GUIs initially, right? If so, wouldn't it be possible to remember the last link-target instead of just the target-class?

Kind regards!

thibsy avatar Jul 15 '22 09:07 thibsy

Hi @smeyer-ilias

I close this PR because IMO this issue should be addressed by a different approach. I won't be adding this automatic node-appendage-mechanism again because I really wan't to enforce some more static behaviour. Thanks for your understanding.

Feel free to contact me if you want to discuss alternative solutions.

Kind regards!

thibsy avatar Dec 14 '22 12:12 thibsy