ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

Published 20 hours ago • verified publisher icon ILIAS-eLearning

8/bugfix/long menu javascript

Open gvollbach opened this issue 2 years ago • 3 comments

Fixed broken Javascript for LongMenu Question

gvollbach avatar May 25 '22 12:05 gvollbach

Copyright checks are failing, since your php classes, do not have the correct copyright header.

gvollbach avatar May 27 '22 06:05 gvollbach

@mbecker-databay, @dsstrassner : If it is ok with you, I will take care of this issue, while fixing the other issues in the Longmenu-Question, as I'm also renaming the files a bit. A PR should follow shortly. I would keep this PR open for the time being as a reminder and take the responsibility to close it. You can assign it to me.

kergomard avatar May 30 '22 13:05 kergomard

@mbecker-databay, @dsstrassner : If it is ok with you, I will take care of this issue, while fixing the other issues in the Longmenu-Question, as I'm also renaming the files a bit. A PR should follow shortly. I would keep this PR open for the time being as a reminder and take the responsibility to close it. You can assign it to me.

This is fine for me. I reassign this to you @swiniker. I will leave my assignment due to the TechSquad protocol.

dsstrassner avatar May 30 '22 14:05 dsstrassner

As discussed at today's TechSquad Meeting #4600 / #4626 will be merged after @kergomard vacation. (Or closed)

dsstrassner avatar Aug 18 '22 09:08 dsstrassner

Thank you very much for this PR @gvollbach and sorry it took me so long to get back to you. We were in the process of completely rebuilding the Javascript for the LongMenu-Question (See: #4626) and after that it got lost in my queue. I think all the issues you tackle in this PR are fixed by now. Sorry again and best, @kergomard

kergomard avatar Sep 30 '22 12:09 kergomard