ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

Remove old usages of notifications from external consumers

Open iszmais opened this issue 2 years ago • 1 comments

Since the major changes inside of then notifications for trunk (see https://docu.ilias.de/goto_docu_wiki_wpage_6494_1357.html) this occurences dont have any functionality within the current state.

This is a proposal to remove this occurences.

iszmais avatar Apr 25 '22 10:04 iszmais

Hi @alex40724 ,

I stumbled upon two occurences/usages of the JS code located in Services/Notifications/templates/default/notifications.js. Consuming this code only worked 'by accident' and was neither documented as public API nor was it the intention to directly use the JavaScript functions. That being said the creation of those notifications will/should probably not work in trunk with the new integrated notifcation due to major conceptional changes (the visiuals of the notifications are now created server side and fetched within a XHR request, instead of beeing created by the JavaScript itsself). It seems to me those don't fullfill any purpose and are mostly used as a wrokaround. But I'm not fully aware of the scope of this occurences, so this is just a wild guess.

I would appreciate if you could maybe provide me with more information about the usages and would offer to open or change this PR into a refactoring, if we agree on a purpose of those occurences. Otherwise we may just could delete them with this PR.

Feel free to give me a response to that or lets have a quick call if this is getting more complex than estimated.

Greeting, @iszmais

iszmais avatar Apr 25 '22 10:04 iszmais

@iszmais Thanks for the PR. Indeed this code is not in use anymore, I just removed it.

alex40724 avatar Nov 08 '22 08:11 alex40724