WIP: Refactoring DataCollection

[mstuder]

Hi @pascalseeland

Can you please have a look at my proposal.

@mjansenDatabay is this proposal within the boundaries of which a maintainer has?

Targets:

• get rid of ILIAS specific services within ilias components.
• show case of possibility of modularisation of ILIAS
• the maximum of liberty for maintainers - they name the services and use the service signature as they require and adapt the 'foreign' generalized ilias services to their needs

References:

• https://blog.allegro.tech/2020/05/hexagonal-architecture-by-example.html
• https://github.com/dziadeusz/hexagonal-architecture-by-example

If you don't like it, I will not continue with this work and place all the DIC dependencies in the constructor of the DataCollection GUI classes. The work is in progress. But i think the idea should be clear. If not - please ask!

Best regards Martin

[mjansenDatabay]

Hi @mstuder,

for me your approach is totally fine. Other maintainers also introduced new local patterns with ILIAS 8 (e.g. here https://github.com/ILIAS-eLearning/ILIAS/pull/3998).

Best regards, @mjansenDatabay

[mstuder]

@mjansenDatabay thank you so much for your prompt and positive feedback!!

all the best martin

[Amstutz]

Fixing issues around ILIAS 8 in the DC I can say, that this has been done but only partly and lead to many issues. Please if you do refactorings for ILIAS core in future, do it completely and do not stop halfway and drop the issues on somebody elses labs. thx.