ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

#31325 - Do not show TOC if it is disabled

Open padvincenzo opened this issue 3 years ago • 3 comments

Hi, I've added this condition before the method isTocNecessary() so that the TOC won't be displayed if it is deactivated from the "Menu" settings of the module.

Also, I think that the method isTocNecessary() is somehow messed up, I didn't get it.

padvincenzo avatar Dec 30 '21 08:12 padvincenzo

Hi @padvincenzo,

I have classified this as "improvement", since there is no ticket linked here.

If your PR contains a bugfix please reference the number of the mantis ticket in the title 12345 - To many spaces, link the ticket in the description and label the ticket with bugfix.

Rules for Contributors

Thanks a lot for contributing to ILIAS!

klees avatar Dec 30 '21 10:12 klees

Hi @klees, This PR fix the bug mentioned on mantis: https://mantis.ilias.de/view.php?id=31325

padvincenzo avatar Dec 30 '21 10:12 padvincenzo

Dear @alex40724 While checking on old open PRs in the frame of our Technical Board Meeting we stumbled over this one that is getting a little long in the tooth. Could you please either close it with an explanation, give feedback or merge? Thank you very much! @kergomard in the name of the TB

kergomard avatar Oct 04 '22 05:10 kergomard

Sorry for the delay. See my comment in https://mantis.ilias.de/view.php?id=30027

The mentioned setting never controlled the side/slate tree. It is a menu setting, which became obsolete with ILIAS 6. See also the comment in the bug report.

alex40724 avatar Nov 07 '22 09:11 alex40724