ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

Published 20 hours ago • verified publisher icon ILIAS-eLearning

CI: activate captain hook and fix codestyle before commitook + Windows approved

Open lscharmer opened this issue 3 years ago • 13 comments

As #4930 already adds the git hooks from captainhook this PR just removes the --dry-run option from the captainhook.json to automatically fix the codestyle before commiting.

As a side note: The captainhook git hooks are executed with /usr/bin/env php. Therefore $ which php must point to php8.0 or php8.1. Linting will fail under php7.4.

lscharmer avatar Dec 16 '21 09:12 lscharmer

Jour Fixe, 10 JAN 2022 : We highly appreciate this suggestion and accept the PR for trunk.

matthiaskunkel avatar Jan 10 '22 13:01 matthiaskunkel

@lscharmer / @daniwe4 I stumbled upon an issue today (actually I thought about this some weeks ago and today I finally found time to check this): According to our documentation, a custom configuration file can be specified when installing CaptainHook. This unversioned file in turn includes the captainhook.json file provided by ILIAS.

If we force the installation with the specified file (like we do with this PR), the GIT hooks will be overwritten each time post-autoload-dump is fired and the custom file is not respected anymore.

mjansenDatabay avatar Jan 31 '22 14:01 mjansenDatabay

Added libs/composer/captainhook.php to check for the captainhook.local.json.

lscharmer avatar Feb 22 '22 10:02 lscharmer

My plan is to merge this if the trunk is open for ILIAS 9.

mjansenDatabay avatar May 03 '22 14:05 mjansenDatabay

@lscharmer Could you please "fix" the license header :-)?

mjansenDatabay avatar May 03 '22 14:05 mjansenDatabay

Thx @lscharmer I'll merge this if the trunk is open for ILIAS 9 changes.

mjansenDatabay avatar May 24 '22 18:05 mjansenDatabay

The installation part is solved with https://github.com/ILIAS-eLearning/ILIAS/pull/4930 . This PR still provides an added value because of the changed hooks.

mjansenDatabay avatar Aug 12 '22 12:08 mjansenDatabay

@lscharmer Could you please rebase this PR? Because https://github.com/ILIAS-eLearning/ILIAS/pull/4930 is now part of the trunk, we don't need the custom scripts anymore. So the only change relevant for the trunk integration is the change in the captainhook.json file.

mjansenDatabay avatar Aug 22 '22 11:08 mjansenDatabay

I added the JF label to create awareness for this chang (, again).

mjansenDatabay avatar Aug 26 '22 09:08 mjansenDatabay

Jour Fixe, 19 SEP 2022 : Michael wants to notify all developers about this change.

matthiaskunkel avatar Sep 19 '22 13:09 matthiaskunkel

Hi @mjansenDatabay

As Technical Board, we regularly check for pull requests that have been open for a long time. Any Updates on this? Note, that you can also close this, if you are not able or if you not have the ressources to look into it in detail.

Best regards!

chfsx avatar Jan 24 '23 12:01 chfsx

Hi @mjansenDatabay

As Technical Board, we regularly check for pull requests that have been open for a long time. Any Updates on this? Note, that you can also close this, if you are not able or if you not have the ressources to look into it in detail.

Best regards!

klees avatar Sep 19 '23 11:09 klees

Hi @mjansenDatabay

As Technical Board, we regularly check for pull requests that have been open for a long time. This here seems to have gotten stuck on the way ;-).

Best regards! @kergomard

kergomard avatar Feb 20 '24 11:02 kergomard